Lua Plugin Question.

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Lua Plugin Question.

Chou, Peter

Hi,

 

I am unable to over-ride the negative caching lifetime for a transaction via the Lua plugin.

 

In the code, I found this (under 6.2.1 and master) --

ts_lua_http_config.c:  TS_LUA_CONFIG_HTTP_NEGATIVE_CACHING_ENABLED                 = TS_CONFIG_HTTP_NEGATIVE_CACHING_ENABLED,

ts_lua_http_config.c:  TS_LUA_CONFIG_HTTP_NEGATIVE_CACHING_LIFETIME                = TS_CONFIG_HTTP_CACHE_WHEN_TO_REVALIDATE,

 

Shouldn’t the two sides match?

 

After making the obvious correction it seems to work. If there are no issues or other reason for this I will open a PR.

 

Thanks,

Peter

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Lua Plugin Question.

Shu Kit Chan
Great catch! Please submit a PR. Thanks.

On Mon, May 22, 2017 at 12:48 PM, Chou, Peter <[hidden email]> wrote:

> Hi,
>
>
>
> I am unable to over-ride the negative caching lifetime for a transaction via
> the Lua plugin.
>
>
>
> In the code, I found this (under 6.2.1 and master) --
>
> ts_lua_http_config.c:  TS_LUA_CONFIG_HTTP_NEGATIVE_CACHING_ENABLED
> = TS_CONFIG_HTTP_NEGATIVE_CACHING_ENABLED,
>
> ts_lua_http_config.c:  TS_LUA_CONFIG_HTTP_NEGATIVE_CACHING_LIFETIME
> = TS_CONFIG_HTTP_CACHE_WHEN_TO_REVALIDATE,
>
>
>
> Shouldn’t the two sides match?
>
>
>
> After making the obvious correction it seems to work. If there are no issues
> or other reason for this I will open a PR.
>
>
>
> Thanks,
>
> Peter
Loading...